Make assistive-mml unset speech/braille and vice-versa#1388
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1388 +/- ##
========================================
Coverage 86.49% 86.49%
========================================
Files 340 340
Lines 85813 85813
Branches 4815 4815
========================================
Hits 74220 74220
Misses 11593 11593 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zorkow
reviewed
Nov 18, 2025
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
As we are using it already in 4 places, would it make sense to move the pretend we're loading hack into a separate method like
function withoutRerendering(exec: () => void) {
Math.loading++;
exec();
Math.loading--;
}
Member
Author
|
I've added the function you requested (I had meant to do something like that and forgot). I also added some text to the help dialog indicating the new menu behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the menu items for speech/Braille and hidden MathML so that selecting hidden MathML will turn off speech and Braille, and vice versa. That makes is a little easier to switch the type of assistive support to be used. (It really doesn't make sense to have both speech/braille and assistive MathML on at once in any case.)